Automatically chunk large request bodies #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
added
the
semver/minor
second attempt
third attempt
fourth attempt
Lukasa
reviewed
Aug 30, 2023
|
@Lukasa anything else? |
Lukasa
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the
HTTPClientRequest.Bodyis created from a type that is notByteBuffer, we need to convert it to it at some point.ByteBuffercan only hold up toInt32.maxon 32-bit platforms andUInt32.maxon 64-bit platforms and crashes if it exceeds this size limit.Modification
some Sequence<UInt8>,some Collection<UInt8>,some RandomAccessCollection<UInt8>andStringin lazy chunks if the input exceeds 4 MB.some Sequence<UInt8>is special as it can't be efficiently chunked lazily. Therefore we need to do the chunking eagerly if it implements the fast pathwithContiguousStorageIfAvailable. Otherwise we do the chunking lazy but "slowly".HTTPClientRequest.BodytoAsyncSequenceto make testing easier.Result
Converting from
some Sequence<UInt8>,some Collection<UInt8>,some RandomAccessCollection<UInt8>andStringtoByteBufferwill no longer crash for inputs that are larger than 4GB. Conversion above 4MB is now more memory efficient as we do it lazily and not eagerly all at once.