Remove tests relying on OS-dependent behaviour #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation URL parsing has changed in macOS Sonoma and associated releases. Our tests were reliant on the old behaviour. The behaviour is controlled by the OS on which the program was linked, which makes it impossible for us to programmatically work out which result we should see. The affected tests are not actually useful, we don't really care how the URLs parse, so we can safely just remove them. Modifications Remove the affected tests. Result Tests pass!
Lukasa
added
the
semver/none
dnadoba
approved these changes
Aug 10, 2023
FranzBusch
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
URL parsing has changed in macOS Sonoma and associated releases. Our tests were reliant on the old behaviour. The behaviour is controlled by the OS on which the program was linked, which makes it impossible for us to programmatically work out which result we should see.
The affected tests are not actually useful, we don't really care how the URLs parse, so we can safely just remove them.
Modifications
Remove the affected tests.
Result
Tests pass!