Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Swift 5.5 #686

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Drop Swift 5.5 #686

merged 1 commit into from
Apr 14, 2023

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Apr 14, 2023

Motivation

Per our support policy, with the release of 5.8 we are no longer support Swift 5.5.

Modifications

  • Drop infrastructure supporting 5.5
  • Remove conditional compilation guards.

Result

Nice clean Swift 5.6+ repository

@dnadoba dnadoba added the semver/minor For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Apr 14, 2023
@dnadoba
Copy link
Collaborator Author

dnadoba commented Apr 14, 2023

Hey @yim-lee, can we drop the 5.5 builder here?

@yim-lee
Copy link
Contributor

yim-lee commented Apr 14, 2023

can we drop the 5.5 builder here?

@dnadoba Done

Lukasa
Lukasa approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love a negative diff like this.

@Lukasa Lukasa merged commit d62c475 into swift-server:main Apr 14, 2023
@dnadoba dnadoba deleted the dn-drop-5.5 branch April 14, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/minor For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadoba @yim-lee @Lukasa