Allow DNS override #675
Merged
Allow DNS override #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it can be useful to connect to one host e.g. `x.example.com` but request and validate the certificate chain as if we would connect to `y.example.com`. This is what this PR adds support for by adding a `dnsOverride` configuration to `HTTPClient.Configuration`. This is similar to curls `—resolve-to` option but only allows overriding host and not ports for now.
dnadoba
added
the
semver/minor
Lukasa
reviewed
Mar 29, 2023
| @@ -434,7 +434,7 @@ extension HTTPConnectionPool.ConnectionFactory { | |||
| } | |||
| #endif | |||
|
|
|||
| let sslServerHostname = self.key.connectionTarget.sslServerHostname | |||
| let sslServerHostname = self.key.serverNameIndicatorOverride ?? self.key.connectionTarget.sslServerHostname | |||
There was a problem hiding this comment.
Should we hide this in a computed property on the key so as to centralise the knowledge of how to do this?
There was a problem hiding this comment.
Done. Actually found through this another place where I forgot to use the override, namely if we proxy:
f296aa4
Lukasa
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it can be useful to connect to one host e.g.
x.example.combut request and validate the certificate chain as if we would connect toy.example.com. This is what this PR adds support for by adding adnsOverrideconfiguration toHTTPClient.Configuration. This is similar to curls—resolveoption but only allows overriding host and not ports for now.