Fix crash if connection is closed very early #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the channel is closed before flatMap is executed, all ChannelHandler are removed and `TLSEventsHandler` is therefore not present either. We need to tolerate this even though it is very rare. Testing ideas welcome. Fixes swift-server#670
dnadoba
added
the
semver/minor
Lukasa
requested changes
Mar 13, 2023
| channel.pipeline.removeHandler(tlsEventHandler).map { (channel, negotiated) } | ||
| } | ||
| } catch { | ||
| precondition(channel.isActive == false, "if the channel is still active then TLSEventsHandler must be present but got error \(error)") |
There was a problem hiding this comment.
I don't think this precondition is particularly wise: the connection pool will appropriately handle this. Let's drop it to assert instead.
Lukasa
approved these changes
Mar 14, 2023
|
Can you clean up soundness? |
dnadoba
added
semver/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the channel is closed before flatMap is executed, all ChannelHandler are removed and
TLSEventsHandleris therefore not present either. We need to tolerate this even though it is very rare.Testing ideas welcome.
Fixes #670