Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NIOSendable with Sendable #640

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Replace NIOSendable with Sendable #640

merged 1 commit into from
Oct 12, 2022

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Oct 11, 2022 •
edited
Loading

We now require Swift 5.5.2 which includes Sendable so we no longer require the NIOSendable workaround.
NIOSendable is just a typealias of Sendable so this is a non source breaking change.
This allows swift-nio to eventually deprecate NIOSendable.

Lukasa
Lukasa reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the rationale for this?

@dnadoba dnadoba marked this pull request as ready for review October 11, 2022 23:45
@dnadoba
Copy link
Collaborator Author

dnadoba commented Oct 11, 2022

I have updated the description.

@Lukasa Lukasa added the semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Oct 12, 2022
@Lukasa Lukasa merged commit 0b5bec7 into swift-server:main Oct 12, 2022
@dnadoba dnadoba deleted the dn-remove-niosendable branch October 12, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @Lukasa