Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable logging by default and add timeout API #549

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Disable logging by default and add timeout API #549

merged 1 commit into from
Feb 1, 2022

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Feb 1, 2022

This PR makes the logger parameter of execute optional and will use a no-op logger if nil.
In addition, it also adds a new execute method which takes a timeout instead of a deadline.

@dnadoba dnadoba added the semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Feb 1, 2022
@dnadoba
Copy link
Collaborator Author

dnadoba commented Feb 1, 2022

@swift-server-bot test this please

@dnadoba dnadoba merged commit 14c95bf into swift-server:main Feb 1, 2022
@dnadoba dnadoba deleted the dn-timeout-and-default-logger branch February 1, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @fabianfett