Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests in HTTPClientSOCKSTests #498

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Nov 25, 2021

Motivation

fixes #497

Changes

Bind to a port a random free port defined by the operating system instead of using 1080

@dnadoba
Copy link
Collaborator Author

dnadoba commented Nov 25, 2021

@swift-server-bot test this please
Looks like it is fixed. But just to be sure let's run it a couple of times.

@dnadoba dnadoba added the semver/none For PRs that when merged do not need a bump in version number. label Nov 25, 2021
@dnadoba
Copy link
Collaborator Author

dnadoba commented Nov 25, 2021

@swift-server-bot test this please
Great, and another time

@dnadoba
Copy link
Collaborator Author

dnadoba commented Nov 25, 2021

@swift-server-bot test this please
One last time

@dnadoba dnadoba merged commit f2bb283 into swift-server:main Nov 25, 2021
@dnadoba dnadoba deleted the dn-fix-flaky-socks-tests branch November 25, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky tests in HTTPClientSOCKSTests if run in parallel
2 participants