[ConnectionPool] Preserve connection errors #421
Merged
+127
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
changed the title
fabianfett
added
semver/none
Lukasa
approved these changes
Sep 10, 2021
| @@ -26,6 +26,8 @@ extension HTTPConnectionPool { | |||
|
|
|||
| private var connections: HTTP1Connections | |||
| private var failedConsecutiveConnectionAttempts: Int = 0 | |||
| /// the error from the last connection creation | |||
| private var lastConnectFailure: Error? | |||
There was a problem hiding this comment.
Possible future enhancement: store a vector of errors and throw a single, composite error that encompasses them all.
fabianfett
force-pushed
the
ff-better-error-messages
branch
from
2408ef4
to
701c1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we can't establish a connection to a remote for the user, we will retry to create the connection. Eventually the requests connection timeout will fire, and we will fail the request. Right now we fail the request always with the
HTTPClientError.getConnectionFromPoolTimeouterror. While this is very descriptive, it does not tell the user if there are to many waiting requests or if there was a connection problem.Changes
Result
If user have a typo in their url, they will get better errors. (dns failure)