Make Swift 5.2 the minimum required version #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
semver/patch
|
Hey @yim-lee , would you be able to sort out the CI for this please? We need a few things:
|
|
@swift-server-bot test this please |
yim-lee
reviewed
Jun 22, 2021
There was a problem hiding this comment.
@Davidde94 CI changes are done. There is an issue with 1604.52.yaml that needs to be addressed but otherwise this should be good to go.
docker/docker-compose.1604.52.yaml
Outdated
|
|
||
| test: | ||
| image: async-http-client:16.04-5.2 | ||
| environment: [] |
There was a problem hiding this comment.
Remove []
+ docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.1604.52.yaml -p async-http-client-swift52-prb build --pull
yaml.parser.ParserError: while parsing a block mapping
in "./docker/docker-compose.1604.52.yaml", line 13, column 5
expected <block end>, but found '<block sequence start>'
in "./docker/docker-compose.1604.52.yaml", line 15, column 7
Build step 'Execute shell' marked build as failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're applying this change across all of the NIO family of projects.
I've removed the docker files for earlier versions, and set the tools version. I've also added a brief note inside the contributing guide.