Fix doc comment for redirectConfiguration #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`redirectConfiguration` can't default to `false` as it's not a boolean value, and the default value is `RedirectConfiguration()`.
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can't @swift-server-bot ever post just a single comment? 🤔 |
|
Swift server bot is just very enthusiastic. |
|
@swift-server-bot test this please |
Lukasa
approved these changes
Jun 19, 2020
|
CC @tomerd regarding the overly enthusiastic @swift-server-bot |
|
@swift-server-bot add to whitelist |
artemredkin
approved these changes
Jun 22, 2020
|
thank you, @MaxDesiatov ! |
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this pull request
Jun 23, 2020
`redirectConfiguration` can't default to `false` as it's not a boolean value, and the default value is `RedirectConfiguration()`. Co-authored-by: Johannes Weiss <[email protected]> Co-authored-by: Artem Redkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirectConfigurationcan't default tofalseas it's not a boolean value, and the default value isRedirectConfiguration().