Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash in
testUncleanCloseThrows
.Motivation:
This PR aims to fix two issues:
.closed
, so it's a completely normal situatuonNIOHTTP1TestServer
, where we wait for.head
before we attempt to shutdown the client.Modifications:
testUncleanCloseThrows
to useNIOHTTP1TestServer
to eliminate a raceConnectionState.swift
connectFailed
is working as expected when the client is.closed
Result:
Closes #248