cpool: don't reuse connection if we sent close #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Previously, we'd only use the server's connection header to determine if we should close the connection or not. That's wrong because if we set `connection: close` ourselves, we must not reuse again. Modification: Set `TaskHandler.closing = false` if we send a close header. Result: More HTTP correctness.
artemredkin
approved these changes
May 21, 2020
|
hit #226 , retrying |
|
@swift-server-bot test this please |
|
swiftpm bug. Not filing because it's the 5.0 one, if we see this on 5.2 we should file |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously, we'd only use the server's connection header to determine if
we should close the connection or not. That's wrong because if we set
connection: closeourselves, we must not reuse again.Modification:
Set
TaskHandler.closing = falseif we send a close header.Result:
More HTTP correctness.