Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix malformed cookie parsing #210

Merged
merged 2 commits into from
May 13, 2020
Merged

fix malformed cookie parsing #210

merged 2 commits into from
May 13, 2020

Conversation

artemredkin
Copy link
Collaborator

Fixes malformed cookie parsing, closes #209.

Motivation:
We do not check that cookie component name could be empty, assuming that split array is not empty, that could lead to crash.

Modifications:

  1. return empty pairs if split array is empty
  2. add a test

Result:
Cookie parsing is more robust.

@artemredkin artemredkin requested review from weissi and Lukasa May 13, 2020 13:23
@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

@artemredkin artemredkin merged commit 0fbfdcc into master May 13, 2020
@artemredkin artemredkin deleted the fix_malformed_cookie_parsing branch May 13, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@weissi weissi Awaiting requested review from weissi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Untimely client termination on malformed Set-Cookie values
2 participants
@artemredkin @Lukasa