Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix location header lookup #186

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix location header lookup #186

merged 1 commit into from
Mar 31, 2020

Conversation

artemredkin
Copy link
Collaborator

Fix Location header case-sensitive lookup, closes #185

Motivation:
HTTP Header names are case-insensitive.

Modifications:
Use .first method provided by HTTPHeaders
Remove cookieHeaders method and instead use getter provided by HTTPHeaders

Result:
Redirects will now be processed correctly.

@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

@artemredkin artemredkin merged commit 2fcf0a9 into master Mar 31, 2020
@artemredkin artemredkin deleted the fix_header_comparison branch March 31, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@weissi weissi Awaiting requested review from weissi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headers should be case insensitive
2 participants
@artemredkin @Lukasa