some lets in Requests were vars by accident #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Generally, most members in
struct
s should bevar
but in this particular case,let
makes more sense (for now) because there are other properties (likekind
) that are generated from things like host/port/scheme. If we allowscheme
to becomevar
, then we would need to updatekind
when changed, however that wasn't done.Also, the
var
functionality wasn't tested and therefore we should restore the behaviour of 1.0.1 which was to store them aslet
s.Modification:
make the
method
,url
, andscheme
members ofRequest
alet
.Result:
Harder to make an illegal
Request
value.