Implement a basic RESP3Token parser #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
commented
Jul 5, 2023
| case canNotParseBigNumber | ||
| } | ||
|
|
||
| private let base: Base |
There was a problem hiding this comment.
Could we add an index here? That way we can correlate the error back to a specific location in the received ByteBuffer. Definitely helps debugging should this ever trigger
There was a problem hiding this comment.
I do understand and appreciate the feature request. However is that something that we can put off for later?
There was a problem hiding this comment.
Sounds good, do you want me to make an issue for this?
Joannis
commented
Jul 5, 2023
fabianfett
approved these changes
Jul 5, 2023
|
Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.