Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial provider token fixes. #49

Merged
merged 12 commits into from
Sep 24, 2019
Merged

Initial provider token fixes. #49

merged 12 commits into from
Sep 24, 2019

Conversation

kylebrowning
Copy link
Member

fixes #42

@kylebrowning kylebrowning mentioned this pull request Sep 23, 2019
Closed
@kylebrowning kylebrowning added this to the 1.2.0 milestone Sep 23, 2019
@kylebrowning
Copy link
Member Author

CC @weissi @itcohorts @MaciejGad

weissi
weissi requested changes Sep 24, 2019
View reviewed changes
Copy link
Collaborator

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great to have a test for this now! However, changing struct to class is public API breaking, therefore I'm requesting changes here.

@kylebrowning
Copy link
Member Author

OKay so @weissi Tests currently break. I advancing time forward doesn't actually change DispatchTime.now()

So im not really sure how I could validate that it works via tests.

My manual testing worked perfectly though.

@kylebrowning kylebrowning merged commit 46e602a into master Sep 24, 2019
@kylebrowning kylebrowning deleted the provider-token-fixes branch September 24, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebrowning @weissi