Make APNSError.reason public again #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restores public access to the `APNSError.reason` property, because it's needed for library users handling APNs errors. (The status code is not an viable alternative, as there are multiple different error reasons for one status code.) The `reason` property was unintentionally set to private in commit ecf0f44 (Breakout APNSwift into packages (swift-server-community#170)). Notably, the associated type ErrorReason remained public.
0xTim
approved these changes
Apr 11, 2023
|
yup! I was talking with Franz about this just to understand why we did it in the first place, but this pr can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restores public access to the
APNSError.reasonproperty, because it's needed for library users handling APNs errors. (The status code is not an viable alternative, as there are multiple different error reasons for one status code.)The
reasonproperty was unintentionally set to private in commit ecf0f44 (Breakout APNSwift into packages (#170)). Notably, the associated type ErrorReason remained public.