Add support for dismissal-date to live activity notification #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated APNSLiveActivityNotification to accept a dismissal date as unix timestamp value. Added unit tests to validate JSON encoding of APNSLiveActivityNotification. Added extension to Int to provide dismissImmediately constant. Updated examples in README.md
kylebrowning
approved these changes
Jan 2, 2023
Sources/APNSwift/LiveActivity/APNSLiveActivityNotification.swift
Outdated
Show resolved
Hide resolved
FranzBusch
reviewed
Jan 5, 2023
Sources/APNSwift/LiveActivity/APNSLiveActivityNotification.swift
Outdated
Show resolved
Hide resolved
Sources/APNSwift/LiveActivity/APNSLiveActivityNotificationAPSStorage.swift
Outdated
Show resolved
Hide resolved
* Added APNSLiveActivityDismissalDate struct * Cleaned up unrequired imports * Updated to use new struct for specifying dimissal time * Updated live activity unit tests to use new struct
|
Thanks @mark-urbanthings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation didn't have support for
dismissal-dateso have added support to the current beta. Code is working in prototype Vapor live notification service we've been working on. Changes:dismissImmediatelyconstant.README.mdWould be helpful if this accepted - thanks!