Refactor configuration and client #143
Merged
+1,022
−732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is doing multiple things in once and I can't split them apart since the client and the configuration are tightly coupled. The goals of this PR is to create an evolable API that we can use to build more semantically safe constructs. Furthermore, it splits the configuration properly between what can be configured on a single connection and what can be configured on a request.
Modification
In details this PR does the following things:
send
method.Result
We now have a new config and a baseline client that allows us to build semantically safe APIs in the next PRs.