Convert to Async Await, Add configurable environments, remove deprecated code #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrowning
added
the
needs-major-version-bump
This was referenced Jun 9, 2022
Closed
|
@lgaches, @TimAEllis, @LukasCZ any interest in testing I didn't break anything for you? |
|
Sure, I can test. Would be nice to update also the README file sample code. |
|
Will definitely update the readme! |
|
It's working for me |
lgaches
reviewed
Jun 10, 2022
|
I made just a few more changes. but mostly just hiding things from the public namespce |
kylebrowning
force-pushed
the
kb/async-await
branch
from
2039a54 to
99d5252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following.
These are all breaking changes and as such will require a major version bump