Add complication push type #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrowning
approved these changes
Apr 8, 2022
kylebrowning
pushed a commit
that referenced
this pull request
May 10, 2023
Co-authored-by: Lukas Petr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on my watch app and implementing support for using push notifications to update my watch face complications, I found out that APNSwift is missing the complication push type (which is necessary for these kind of notifications).
Since
APNSwiftConnection.PushTypeenum is already backed by String, and its raw value is used when encoding the request, I found that simply adding a new case to that enum was enough to make it work.Thank you so much for creating APNSwift, it's super useful!