Clean up login dialog #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reload is already automatically triggered if the model changes in the simulator context.
Overwriting FSD settings from the connect page (instead of changing the server settings itself) introduced some complexity in the UI. As spontaniously changing the FSD settings is likely a VERY rare use-case and to simplify the logic/UI, it should only be done from the server settings itself.
… tab This should make the component more reusable, for example in non-advanced environments.
This label will already be added by the parent components.
All functionalities from the advanced dialog are also available somewhere else.
This functionality was rarely known.
This feature does not work anymore anyway with the AUTOMATIC VATSIM server
These settings are already available on the model matching side. For simplicity they should only be available at a single place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.