Context cleanup #276
Merged
Context cleanup #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other methods in this component to open and delete the file only worked in a local environment as well. For simplification allow writing this file locally only as well.
Remote file operations via DBus are no longer used
The context returns CSimpleCommandParser::commandsHtmlHelp() as well
According to C++ Core Guideline C.133, protected data should be avoided because they introducing complexity and bugs. In this case for example, the implementing contexts could just change the m_debugEnabled member instead calling setDebugEnabled() if not paying attention. setDebugEnabled() also emit a signal on change, which is accidentially not emitted otherwise.
This method was only uses to provide a secondary way installing the terrain probe. For simplicity we should only provide a single way to install the probe (through the config wizard).
Enabling the terrain probe only works when running locally because it directly accesses the simulator plugin.
To reduce complexity, there should only be a single way to start the AFV client (done on connectionStatusChange of IContextNetwork)
This also removes a dependency of the network context from the OwnAircraft context
Always use the VATSIM online map instead of providing our own map widget
The LED is a leftover from the pre-AFV voicerooms. The LED does not light up when connected to UNICOM or CTAF frequencies which still can be used to transmit & receive voice. This also removes the functionality that the currently tuned station was displayed when hovering over the "COMx" label. This feature was not documented and not known by many users. By removing these features, one context method is no longer required, which further decouples the network context from the OwnAircraft context.
This setting is simulator specific and can already be adjusted from the simulator plugin settings. To avoid complexity, it should only be adjustable from one location. As this setting doesn't need to be adjusted often inflight, it should be fine to not have it directly accessible. This also fixes a previous issue, where a change of the setting within the simulator plugin settings did not propagated to the cockpit page.
ltoenning
force-pushed
the
context_refactoring
branch
from
164c037
to
0dba1b8
Compare
ltoenning
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.