Clean up settings component #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality was already integrated into build.py
The update info is already automatically fetched from GitHub instead of using the distribution.json from the datastore
Use requests library
oktal3700
approved these changes
Mar 21, 2024
As the datastore now has real (no self-signed) TLS certificates, the host verification should not be disabled by default. When testing locally, one could use non-TLS connections.
As a black text color is enforced for the menu, we should also enforce a white background for a good contrast. This is more or less a workaround as this does not respect any system style settings (dark mode, ...). This fix will become obsolete once tackling #138 (removing/reducing stylesheet). Fixes #139
Spreading the information about the ecosystem into all "low-level" readers, just to deactivate them when not using a non-VATSIM ecosystem, should be avoided. Instead, the readers should be disabled entirely from the outside . This will be done in a upcoming refactoring (separate PR).
The hotkeys were only implemented for some tabs as this was likely forgotten for the new tabs. As this feature was likely not used very often and to reduce the maintanance burden, this commit removes this feature.
ltoenning
force-pushed
the
setting_hotkeys
branch
from
6200d10
to
0b6012f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hotkeys were only implemented for some tabs as this was likely forgotten for the new tabs. As this feature was likely not used very often and to reduce the maintenance burden, this PR removes this feature.