Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping to latest version of libswiftnav #1451

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

pcrumley
Copy link
Contributor

@pcrumley pcrumley commented Oct 15, 2024

For some reason, the proc_macro of swiftnav-sys is failing on MacOS and Windows but succeeding on Linux. I'm no sure why but it appears there is some precedent for this: rust-lang/rust#59998

When I update the version to the latest version v0.10.0 it succeeds.

I would recommend getting dependabot to bump these versions in the future and also updating the CI/CD to run on a build matrix with cargo c --all-features

Description

@swift-nav/algint-team

API compatibility

Does this change introduce a API compatibility risk?

No

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/BOARD-XXXX

@pcrumley pcrumley requested a review from notoriaga as a code owner October 15, 2024 00:54
@pcrumley pcrumley requested a review from jbangelo October 15, 2024 00:54
Copy link

@pcrumley pcrumley requested a review from sokhealy October 15, 2024 18:54
@pcrumley pcrumley merged commit 4f99d87 into master Oct 21, 2024
12 of 13 checks passed
@pcrumley pcrumley deleted the pcrumley/bump-libswiftnav branch October 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants