Add description for constellation identifier to bounds messages [OC-1087] #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakTjernberg
commented
Mar 22, 2024
rust/sbp/src/link.rs
Outdated
| @@ -351,6 +351,7 @@ mod tests { | |||
| assert_eq!(*count.borrow(), 1); | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
@pcrumley What do you think of this change I had to make in order to have CI pass? See https://snav.slack.com/archives/C05HP6S1D2Q/p1711097571216779 for more context
There was a problem hiding this comment.
Hey @IsakTjernberg I was on PTO and just getting back into the swing of things. I think it makes more sense to fix the lints like this #1408 because #[allow(dead_code)] is kind of broad lint.
woodfell
approved these changes
Mar 25, 2024
pcrumley
reviewed
Mar 26, 2024
remove change to allow dead code because no longer required
pcrumley
approved these changes
Mar 26, 2024
|
Thanks @pcrumley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add description for what the constellation identifier means in the orbit&clock bounds, code&phase biases bounds, orbit&clock bounds degradations messages.
API compatibility
Does this change introduce a API compatibility risk?
No, it's just adding clarifying documentation to the SBP spec.
JIRA Reference
https://swift-nav.atlassian.net/browse/OC-1087