Don't use deprecated functions in sbp impl [AP-1089] #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Reimplement
sbp_all_payload_callback_payload
so that it doesn't use deprecated functionsThis function is part of the legacy API and is marked for deprecation. In its current implementation it calls another function in the legacy API (
sbp_frame_callback_register
) which is also marked as deprecated. This will cause a compile time warning from the compiler about the use of deprecated functions.There are a few ways to solve it, but since the functions in question are so simple the quickest and least intrusive way is to simple duplicate the functionality of
sbp_frame_callback_register
insbp_all_payload_callback_register
and tailor it to cope with the different parameters.API compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-1089