Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated functions in sbp impl [AP-1089] #1397

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

woodfell
Copy link
Contributor

@woodfell woodfell commented Jan 1, 2024

Description

@swift-nav/devinfra

Reimplement sbp_all_payload_callback_payload so that it doesn't use deprecated functions

This function is part of the legacy API and is marked for deprecation. In its current implementation it calls another function in the legacy API (sbp_frame_callback_register) which is also marked as deprecated. This will cause a compile time warning from the compiler about the use of deprecated functions.

There are a few ways to solve it, but since the functions in question are so simple the quickest and least intrusive way is to simple duplicate the functionality of sbp_frame_callback_register in sbp_all_payload_callback_register and tailor it to cope with the different parameters.

API compatibility

Does this change introduce a API compatibility risk?

No

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

N/A

JIRA Reference

https://swift-nav.atlassian.net/browse/AP-1089

@woodfell woodfell marked this pull request as ready for review January 2, 2024 00:00
@woodfell woodfell requested review from jungleraptor and a team as code owners January 2, 2024 00:00
@woodfell woodfell changed the title Don't use deprecated functions in sbp impl Don't use deprecated functions in sbp impl [AP-1089] Jan 2, 2024
@woodfell woodfell requested review from RReichert, dgburr and a team and removed request for a team January 2, 2024 00:00
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@woodfell woodfell merged commit 416da16 into master Jan 2, 2024
20 checks passed
@woodfell woodfell deleted the woodfell/dont_use_deprecated_fns branch January 2, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants