Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify timestamping descriptions [AP-1087] #1395

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Clarify timestamping descriptions [AP-1087] #1395

merged 5 commits into from
Jan 3, 2024

Conversation

reimerix
Copy link
Contributor

@reimerix reimerix commented Dec 21, 2023 •
edited
Loading

Description

@swift-nav/devinfra

API compatibility

Does this change introduce a API compatibility risk?

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/AP-1087

@reimerix reimerix requested a review from a team as a code owner December 21, 2023 16:05
pcrumley
pcrumley approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these grammatical issues!

pcrumley
pcrumley reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to bump the build-libsbp docker tag to get this to pass ci. I'm not sure the best way to get in changes which change the generated code (tagging @woodfell because he changed the generated ci checks recently)

@reimerix reimerix requested review from jungleraptor, a team and notoriaga as code owners December 22, 2023 17:17
@woodfell
Copy link
Contributor

No, I don't think this is a tag issue. Not all languages have been generated. This PR is (I think) missing:

  • java
  • jsonschema
  • protobuf
  • python
  • quicktype

@reimerix reimerix requested a review from a team as a code owner January 3, 2024 01:16
@woodfell woodfell removed the request for review from a team January 3, 2024 01:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@woodfell woodfell merged commit 2df29c8 into master Jan 3, 2024
36 checks passed
@woodfell woodfell deleted the reimerix/ap-1087/fix-timestamping-descriptions branch January 3, 2024 02:30
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrumley pcrumley pcrumley approved these changes

@dgburr dgburr dgburr left review comments

@woodfell woodfell woodfell approved these changes

@jungleraptor jungleraptor Awaiting requested review from jungleraptor

@notoriaga notoriaga Awaiting requested review from notoriaga notoriaga is a code owner

Assignees

@woodfell woodfell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reimerix @woodfell @dgburr @pcrumley