Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel build all C tests from top level makefile [AP-1086] #1394

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

woodfell
Copy link
Contributor

Description

@swift-nav/devinfra

A small change to speed up builds of C tests when using the top level makefile, as is done in all CI stages.

The current makefile has 2 sections which build and run tests. They are similar (one targets a subset of tests for compatibility with big endian machines). They are both written as:

make -j4;
make do-all-tests

Where the first command builds all targets in parallel, and the second runs all the tests sequentially.

However, test targets are not built as part of all so what really happens is the main libsbp target is build in parallel in the first step, then all tests are built and run single threaded in the second stage. This can be easily fixed and sped up by altering the first command to build all test targets using the -j4 flag:

make -j4 build-all-tests;
make do-all-tests

API compatibility

Does this change introduce a API compatibility risk?

No

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

No

JIRA Reference

https://swift-nav.atlassian.net/browse/AP-1086

@woodfell woodfell marked this pull request as ready for review December 19, 2023 02:51
@woodfell woodfell requested a review from a team as a code owner December 19, 2023 02:51
@woodfell woodfell requested a review from RReichert December 19, 2023 02:59
Copy link

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@woodfell woodfell merged commit cf3f252 into master Dec 19, 2023
8 checks passed
@woodfell woodfell deleted the woodfell/parallel_build_c_tests branch December 19, 2023 06:50
@pcrumley
Copy link
Contributor

@woodfell for PRs like this which only affects the libsbp repo it's a good idea to add #no_auto_pr to the title so our Jenkins doesn't do all the submodule updates. Nbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants