Use docker in GA [AP-1085] #1393
Conversation
woodfell
force-pushed
the
woodfell/use_docker_in_ga
branch
from
761af2f to
37f688e
Compare
| - uses: gradle/gradle-build-action@v2 | ||
| with: | ||
| gradle-version: 7.1.1 | ||
| git config --global --add safe.directory /__w/libsbp/libsbp |
There was a problem hiding this comment.
Not sure this is ideal but required to resolve a permissions issue which I think is caused by different UIDs being used inside and outside the container
There was a problem hiding this comment.
I think this is fine/I don't know a better solution here.
There was a problem hiding this comment.
This seems reasonable but I guess I'm curious why you abandoned goal of using latest and switched to a tagged version. I guess my concern is that we could run into this issue where the latest build gets broken if there is a delta between the two.
This situation is a lot better than it was, and very happy to see this work
It's so that we are able to build historical commit moving forwards. It we somehow bork the |
That seems very reasonable, maybe we should put the bumping of the build tag as part of the release process then |
|
Description
@swift-nav/devinfra
Make use of
libsbp-builddocker image in the "check generated artefacts" stage. This bring consistency to the artefacts generated in the CI check since the canonical way of generating libsbp is via the docker image. This PR doesn't actually make any changes but should resolve some of the issues which have been seen recently when generating libsbp locally versus in CI.API compatibility
Does this change introduce a API compatibility risk?
N/A
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-1085