Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove -i option from sed #1389

Merged
merged 1 commit into from
Dec 8, 2023
Merged

remove -i option from sed #1389

merged 1 commit into from
Dec 8, 2023

Conversation

pcrumley
Copy link
Contributor

@pcrumley pcrumley commented Dec 8, 2023

Description

@swift-nav/devinfra

cargo release uses a pre-commit hook to update the sbp2json input to point to the latest sbp release in crates.io

However, the sed version uses the -i flag which is not POSIX defined and will give different results with gnu sed vs BSD sed.

Now this should be good to release from OSX or linux

@pcrumley pcrumley enabled auto-merge (squash) December 8, 2023 22:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

[libsbp-c] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pcrumley pcrumley merged commit d7b3b44 into master Dec 8, 2023
14 checks passed
@pcrumley pcrumley deleted the pcrumley/sed-portability branch December 8, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notoriaga notoriaga notoriaga approved these changes

@jungleraptor jungleraptor Awaiting requested review from jungleraptor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcrumley @notoriaga