rust: check more messages for time validity #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
commented
Nov 14, 2023
| @@ -59,6 +59,12 @@ | |||
|
|
|||
| BASE_TIME_MSGS = ["MSG_OBS", "MSG_OSR", "MSG_SSR"] | |||
|
|
|||
| CHECK_FLAGS = """ | |||
| if self.time_source().ok()? == TimeSource::None { | |||
There was a problem hiding this comment.
Actually like this one more because it checks against a specific variant. So if a message gets added that has a TimeSource but no None state for some reason we'll get a compile error
notoriaga
requested review from
pcrumley,
jungleraptor and
a team
as code owners
pcrumley
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #1375 but accounts for the other 3 time messages and msg_odometry
@swift-nav/devinfra
API compatibility
Does this change introduce a API compatibility risk?
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX