Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: add a /version endpoint to api.py that tells you which version of sweep we're running (✓ Sandbox Passed) #3156

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sweep-nightly[bot]
Copy link
Contributor

@sweep-nightly sweep-nightly bot commented Feb 23, 2024

Description

This pull request adds a /version endpoint to api.py that returns the current version of Sweep.

Summary

  • Modified Dockerfile to set the SWEEP_VERSION environment variable to the current date and time during image build
  • Added a new endpoint /version to api.py that returns the current version of Sweep
  • Added a new file version.py to handle getting the version from the environment variable

Fixes #3151.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-nightly bot commented Feb 23, 2024

Rollback Files For Sweep

  • Rollback changes to Dockerfile
  • Rollback changes to sweepai/api.py
  • Rollback changes to sweepai/utils/version.py

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-nightly bot commented Feb 23, 2024

Apply Sweep Rules to your PR?

  • Apply: We should use loguru for error logging. If the log is inside an exception, use logger.exception to add tracebacks, where logger is imported from loguru. Use f-strings for string formatting in logger calls (e.g. logger.info(f'Hello {name}') instead of logger.info('Hello {name}', name=name)).
  • Apply: There should be no debug log or print statements in production code.
  • Apply: All functions should have parameters and output annotated with type hints. Use list, tuple and dict instead of typing.List, typing.Tuple and typing.dict.
  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the same directory. For example, sweepai/api_test.py tests sweepai/api.py. Use unittest and unittest.mock as required.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.
  • Apply: Remove any comments before code that are obvious. For example # this prints hello world; print('hello world').

This is an automated message generated by Sweep AI.

@sweep-nightly sweep-nightly bot added the sweep Assigns Sweep to an issue or pull request. label Feb 23, 2024
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sweep-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 1:03am

Dockerfile Outdated
@@ -61,6 +61,9 @@ COPY tests /app/tests
ENV PYTHONPATH=.
COPY bin/startup.sh /app/startup.sh
COPY redis.conf /app/redis.conf

# Set the SWEEP_VERSION environment variable to the current date and time during image build
ENV SWEEP_VERSION=$(date +%Y%m%d%H%M)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildx failed with: ERROR: failed to solve: Syntax error - can't find = in "+%Y%m%d%H%M)". Must be of the form: name=value

Copy link
Contributor Author

@sweep-nightly sweep-nightly bot Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

Dockerfile Outdated

# Set the SWEEP_VERSION environment variable to the current date and time during image build
ARG SWEEP_VERSION
ENV SWEEP_VERSION=${SWEEP_VERSION:-$(date +%Y%m%d%H%M)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 2.03kB done
#1 DONE 0.0s
Dockerfile:67

65 | # Set the SWEEP_VERSION environment variable to the current date and time during image build
66 | ARG SWEEP_VERSION
67 | >>> ENV SWEEP_VERSION=${SWEEP_VERSION:-$(date +%Y%m%d%H%M)}
68 | RUN chmod u+x /app/startup.sh
69 |

ERROR: failed to solve: Syntax error - can't find = in "+%Y%m%d%H%M)}". Must be of the form: name=value
Error: buildx failed with: ERROR: failed to solve: Syntax error - can't find = in "+%Y%m%d%H%M)}". Must be of the form: name=value

Copy link
Contributor Author

@sweep-nightly sweep-nightly bot Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

Dockerfile Outdated

# Set the SWEEP_VERSION environment variable to the current date and time during image build
ARG SWEEP_VERSION
ENV SWEEP_VERSION=${SWEEP_VERSION:-"$(date +%Y%m%d%H%M)"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to run this before saving it to an envvar otherwise it's treated as a literal

Copy link
Contributor Author

@sweep-nightly sweep-nightly bot Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

Dockerfile Outdated

# Set the SWEEP_VERSION environment variable to the current date and time during image build
ARG SWEEP_VERSION
RUN export SWEEP_VERSION=${SWEEP_VERSION:-$(date +%Y%m%d%H%M)} && echo "SWEEP_VERSION=$SWEEP_VERSION" >> /etc/environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be written to .env

Copy link
Contributor Author

@sweep-nightly sweep-nightly bot Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a /version endpoint to api.py that tells you which version of sweep we're running
1 participant