feat(plugin_runner): shared runtime engine #7590
Merged
+50
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this might not be needed once this is merged: wasmerio/wasmer#4011 |
|
Yes, saw that but per wasmerio/wasmer#3793 (comment) it is still recommended to reuse if possible? |
kdy1
reviewed
Jun 28, 2023
kwonoj
force-pushed
the
shared-runtime-engine
branch
from
0f251e6 to
3279a21
Compare
kdy1
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Attempt to address suggestion: wasmerio/wasmer#3793 (comment)