refactor(bindings/wasm): deprecate jsvalue::*_serde #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
redux-refactor-break-serde
branch
from
ed5c1a3 to
09d093a
Compare
|
Thanks, looks like rebased on passes ci now. |
kdy1
previously approved these changes
Nov 17, 2022
kwonoj
force-pushed
the
redux-refactor-break-serde
branch
from
09d093a to
dcbb415
Compare
|
I recall I resolved conflicts.. 🤔 anyway, re-rebased. |
kdy1
approved these changes
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Second attempts to #6436, with various fixes to ensure things are not breaking.
PR also adds naive testing to swc_core to test with latest workspace root to build. This allows to catch problems upfront before publish swc_core (not @swc/core). It actually caught various failures while I'm working on this PR.
Also, PR updates
bindings_macroto reflect latest changes.BREAKING CHANGE:
Related issue (if exists):