refactor(plugin_runner): split modules, introduce feature target

[kwonoj]

Description:

• Support plugins in @swc/wasm-* #3934

This PR is internal refactoring to plugin_runner to support wasm host based target (@swc/wasm).

Notable changes are

• plugin_runner now have embedded_runtime, native_runtime features. Embedded stands for existing plugin runner where we need to bring wasmer's runtime. Native means we'll use host runtime as-is, such as browser / node.js's v8 webassembly.
• swc supports those new features via plugin_embedded_runtime / plugin_native_runtime features. Existing plugin is renamed into plugin_embedded_runtime.
• plugin_runner extracts few logics into internal modules as well as branches to each features. Currently native_runtime is empty.
• apply_js_plugin is now renamed to apply_transform_plugin to reflect what we do exactly. Further, we can possibly have other entrypoint like apply_xxx_plugin for css, or else.

[kwonoj]

lint failure comes from

  Checking swc_ecma_transforms_optimization v0.102.0 (/home/runner/work/swc/swc/crates/swc_ecma_transforms_optimization)
error: useless conversion to the same type: `simplify::dce::Data`
   --> crates/swc_ecma_transforms_optimization/src/simplify/dce/mod.rs:410:21
    |
410 |         self.data = data.into();
    |                     ^^^^^^^^^^^ help: consider removing `.into()`: `data`
    |
note: the lint level is defined here
   --> crates/swc_ecma_transforms_optimization/src/lib.rs:1:9

[kdy1]

Thanks!

[kdy1]

Please modify https://github.com/swc-project/swc/blob/5800737752ec8a2befc7010290247b319e671ac3/scripts/github/tests.yml instead

[kdy1]

You can create matrix by running https://github.com/swc-project/swc/blob/5800737752ec8a2befc7010290247b319e671ac3/scripts/github/create-matrix.sh

[kwonoj]

I tried to ran create-matrix.sh and nothing happens. What should be exactly updated to make sure script works?

[kdy1]

You should copy output to the matrix to this file

[kwonoj]

Output doesn't seem to correct to me. Looks like script requires jq / yq, but after installing both I'm getting

...
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6
- crate: testing_macros
  os: ubuntu-latest
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6
- crate: wasm
  os: ubuntu-latest
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6
parse error: Invalid numeric literal at line 1, column 6

[kdy1]

Are you using windows?
Interesting as it specifies bash requirement... I don't think bash parse script differently based on the OS

[kwonoj]

No, it was linux and managed to make it work - script requires to be executed cwd under scripts, does not allow ./scripts/create-matrix.sh from swc's root. It wasn't clear as there wasn't way to see error outputs.

[kdy1]

Why is this required?

I think user of the swc crate can depend on swc_plugin_runner/embedded_runtime or swc_plugin_runner/native_runtime instead?

[kwonoj]

This is probably I'm making some mistakes if you felt bit odd. My thought was each package have deps to swc can select features without transitive deps feature selection, also swc itself uses own feature selection like https://github.com/swc-project/swc/pull/4012/files#diff-8987cc214ab0c7d63b833d31785ecb48d89d1bcc204d42508c26ecd72becc7b9R72 .

[kdy1]

I think this is not required. I'll check using a fork

[kdy1]

I think #4027 will work, except swc_cli on platforms not supported by cranelift. We should exclude them via --no-default-features

[kwonoj]

Superseded by #4035.