Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Merge binding analyzer into infection analyzer #9973

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 29, 2025

Description:

We don't need to split those two visitors.

@kdy1 kdy1 added this to the Planned milestone Jan 29, 2025
@kdy1 kdy1 self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 50c0019

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review January 29, 2025 16:27
@kdy1 kdy1 requested a review from a team as a code owner January 29, 2025 16:27
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 29, 2025
@kdy1 kdy1 changed the title perf(es/minifier): Improve time complexity of usage analyzer perf(es/minifier): Merge binding analyzer into infection analyzer Jan 29, 2025
@kdy1 kdy1 enabled auto-merge (squash) January 29, 2025 16:28
@kdy1 kdy1 requested a review from a team as a code owner January 29, 2025 16:34
@kdy1 kdy1 disabled auto-merge January 29, 2025 16:50
@kdy1 kdy1 merged commit ca8a71f into swc-project:main Jan 29, 2025
167 checks passed
@kdy1 kdy1 deleted the analyzer-time branch January 29, 2025 16:50
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9973 will degrade performances by 15.12%

Comparing kdy1:analyzer-time (50c0019) with main (772cc30)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/terser 622.6 ms 598.7 ms +3.98%
es/full/minify/libraries/vue 290.5 ms 277 ms +4.87%
es/full/base/fixer 118.9 µs 140.1 µs -15.12%

@kdy1 kdy1 modified the milestones: Planned, v1.10.12 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant