Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/ast): Accept any case of EsVersion during deserialization #9329

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 9e6c58f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #9329 will improve performances by 10.07%

Comparing magic-akari:fix/issue-9287 (9e6c58f) with magic-akari:fix/issue-9287 (148097e)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark magic-akari:fix/issue-9287 magic-akari:fix/issue-9287 Change
es/full/bugs-1 602.4 µs 547.3 µs +10.07%
parse_and_babelify_jquery 114.9 ms 111.2 ms +3.28%

@kdy1 kdy1 marked this pull request as ready for review July 24, 2024 14:00
@kdy1 kdy1 requested a review from a team as a code owner July 24, 2024 14:00
@kdy1 kdy1 added this to the Planned milestone Jul 25, 2024
kdy1
kdy1 previously approved these changes Jul 25, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 25, 2024 03:41
@kdy1 kdy1 changed the title fix(es/base): Accept any case of EsVersion during deserialization fix(es/ast): Accept any case of EsVersion during deserialization Jul 25, 2024
@kdy1 kdy1 merged commit 56da6be into swc-project:main Jul 25, 2024
22 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.2 Jul 25, 2024
@magic-akari magic-akari deleted the fix/issue-9287 branch August 7, 2024 06:13
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

unknown variant ESNext
2 participants