Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Use arena allocator for ProgramData #10064

Closed
wants to merge 21 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 20, 2025

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Feb 20, 2025
@kdy1 kdy1 self-assigned this Feb 20, 2025
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: b5b1f3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #10064 will degrade performances by 6.48%

Comparing kdy1:min-arena (779c9d0) with main (52caf23)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 174.2 ms 168.8 ms +3.2%
es/full/minify/libraries/moment 104.8 ms 110.2 ms -4.85%
es/lints/libs/moment 5.7 ms 5.4 ms +5.42%
es/minifier/libs/jquery 131.5 ms 140.6 ms -6.48%

@kdy1
Copy link
Member Author

kdy1 commented Feb 21, 2025

Closing as I'm going to use graphite

@kdy1 kdy1 closed this Feb 21, 2025
@kdy1 kdy1 deleted the min-arena branch February 21, 2025 02:09
@kdy1 kdy1 removed this from the Planned milestone Feb 25, 2025
@kdy1 kdy1 added this to the v1.11.1 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant