fix(ts/fast-strip): Handle unsupported module keyword

[magic-akari]

Related issue:

• Closes: Option to error on module namespaces #10017

[changeset-bot]

🦋 Changeset detected

Latest commit: 987bc96

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[magic-akari]

The implementation is currently in type-strip as it allows us to directly access tokens and source code text, minimizing the risk of AST breaking changes.

It’s unclear whether we can achieve the same in the Transform pass, but it is something we need to try.

@kdy Please let me know your thoughts. Thank you!

[codspeed-hq]

CodSpeed Performance Report

Merging #10022 will degrade performances by 4.49%

_{Comparing magic-akari:es/ts-error-on-module (987bc96) with main (6dab49a)}

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	es/minifier/libs/jquery	127.6 ms	133.6 ms	-4.49%
❌	es/minifier/libs/lodash	148.5 ms	155.4 ms	-4.47%
⚡	typescript/fast-strip	767.5 µs	679.7 µs	+12.92%

[kdy1]

I think I need to make a AST-breaking change tomorrow, so please feel free to work on it. Please tell me if you prefer to make the change with another PR

[magic-akari]

I've found a solution that preserves our current AST structure and avoids introducing any breaking changes. It's straightforward to pass the source text to the Transform pass.

However, if we decide to update the AST, we might consider adding a field to specify the module or namespace. This could also benefit other libraries (such as dprint), though I'm not completely certain about its overall impact.

Which do you prefer?

[kdy1]

I think the latter one is better, but it would be better if AST-breaking change is a separate PR. If it's the case I can align the date of merging with release date of various tools to reduce impact of the breaking changes.

[magic-akari]

I’ve created PR #10023. Please note that this PR is independent of #10023. Once #10023 is merged, we can simplify the namespace detection method accordingly.

[magic-akari]

This is a bit awkward. We could have simply removed the top-level namespace, but we had to dig into the internal nodes to catch the error.

namespace Foo {
    namespace Bar {
        module Boom { }
    }
}