Skip to content

Commit

Permalink
fix(es/loader): Exclude .json from default extension list (#9134)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #9121
  • Loading branch information
@kdy1
kdy1 committed Jul 4, 2024
1 parent 178cbdd commit e94e5e7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/swc_ecma_loader/src/resolvers/node.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ pub struct NodeModulesResolver {
ignore_node_modules: bool,
}

static EXTENSIONS: &[&str] = &["ts", "tsx", "js", "jsx", "json", "node"];
static EXTENSIONS: &[&str] = &["ts", "tsx", "js", "jsx", "node"];

impl NodeModulesResolver {
/// Create a node modules resolver for the target runtime environment.
Expand Down

1 comment on commit e94e5e7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e94e5e7 Previous: b021dd2 Ratio
es/full/bugs-1 301771 ns/iter (± 6748) 273141 ns/iter (± 3426) 1.10
es/full/minify/libraries/antd 1679291084 ns/iter (± 46799885) 1819179032 ns/iter (± 89707179) 0.92
es/full/minify/libraries/d3 336739979 ns/iter (± 670182) 341584652 ns/iter (± 3809176) 0.99
es/full/minify/libraries/echarts 1399853705 ns/iter (± 6262393) 1506707321 ns/iter (± 39328000) 0.93
es/full/minify/libraries/jquery 102026459 ns/iter (± 205356) 102522949 ns/iter (± 272901) 1.00
es/full/minify/libraries/lodash 113615177 ns/iter (± 258867) 113266522 ns/iter (± 524826) 1.00
es/full/minify/libraries/moment 59185002 ns/iter (± 135460) 59194542 ns/iter (± 184584) 1.00
es/full/minify/libraries/react 18270975 ns/iter (± 25046) 18332697 ns/iter (± 54646) 1.00
es/full/minify/libraries/terser 271521397 ns/iter (± 1142233) 272363683 ns/iter (± 1567725) 1.00
es/full/minify/libraries/three 461223702 ns/iter (± 2460040) 463268136 ns/iter (± 2384594) 1.00
es/full/minify/libraries/typescript 3179084968 ns/iter (± 25659583) 3129692905 ns/iter (± 28618913) 1.02
es/full/minify/libraries/victory 709760070 ns/iter (± 4775932) 723225767 ns/iter (± 7476573) 0.98
es/full/minify/libraries/vue 144783597 ns/iter (± 885745) 144741826 ns/iter (± 333808) 1.00
es/full/codegen/es3 61006 ns/iter (± 161) 60515 ns/iter (± 582) 1.01
es/full/codegen/es5 61066 ns/iter (± 1468) 60541 ns/iter (± 315) 1.01
es/full/codegen/es2015 61053 ns/iter (± 171) 60526 ns/iter (± 164) 1.01
es/full/codegen/es2016 60773 ns/iter (± 80) 60484 ns/iter (± 166) 1.00
es/full/codegen/es2017 60813 ns/iter (± 110) 60509 ns/iter (± 501) 1.01
es/full/codegen/es2018 60748 ns/iter (± 128) 60503 ns/iter (± 212) 1.00
es/full/codegen/es2019 60833 ns/iter (± 181) 60814 ns/iter (± 123) 1.00
es/full/codegen/es2020 60737 ns/iter (± 155) 60531 ns/iter (± 298) 1.00
es/full/all/es3 159100409 ns/iter (± 848319) 160660818 ns/iter (± 1038511) 0.99
es/full/all/es5 155416769 ns/iter (± 1731604) 155106438 ns/iter (± 580698) 1.00
es/full/all/es2015 114715259 ns/iter (± 926245) 114156196 ns/iter (± 484297) 1.00
es/full/all/es2016 113861589 ns/iter (± 394355) 113516575 ns/iter (± 1029002) 1.00
es/full/all/es2017 113430769 ns/iter (± 491948) 111978125 ns/iter (± 664018) 1.01
es/full/all/es2018 111832777 ns/iter (± 1163355) 110867826 ns/iter (± 924791) 1.01
es/full/all/es2019 110325047 ns/iter (± 611321) 109786156 ns/iter (± 587030) 1.00
es/full/all/es2020 106999560 ns/iter (± 861239) 106232585 ns/iter (± 1069254) 1.01
es/full/parser 447662 ns/iter (± 2604) 455648 ns/iter (± 4247) 0.98
es/full/base/fixer 15042 ns/iter (± 64) 15247 ns/iter (± 175) 0.99
es/full/base/resolver_and_hygiene 78858 ns/iter (± 218) 80120 ns/iter (± 448) 0.98
serialization of serde 268 ns/iter (± 2) 259 ns/iter (± 11) 1.03
css/minify/libraries/bootstrap 21937143 ns/iter (± 312751) 21743583 ns/iter (± 150521) 1.01
css/visitor/compare/clone 1371753 ns/iter (± 16028) 1371176 ns/iter (± 12150) 1.00
css/visitor/compare/visit_mut_span 1489510 ns/iter (± 8766) 1476934 ns/iter (± 12435) 1.01
css/visitor/compare/visit_mut_span_panic 1504999 ns/iter (± 34645) 1510823 ns/iter (± 43597) 1.00
css/visitor/compare/fold_span 1989771 ns/iter (± 4991) 1999242 ns/iter (± 9955) 1.00
css/visitor/compare/fold_span_panic 2133063 ns/iter (± 5795) 2158979 ns/iter (± 5704) 0.99
css/lexer/bootstrap_5_1_3 3459110 ns/iter (± 7341) 3448506 ns/iter (± 28254) 1.00
css/lexer/foundation_6_7_4 2798793 ns/iter (± 4825) 2792917 ns/iter (± 2741) 1.00
css/lexer/tailwind_3_1_1 536828 ns/iter (± 414) 537385 ns/iter (± 962) 1.00
css/parser/bootstrap_5_1_3 16267961 ns/iter (± 111758) 15943578 ns/iter (± 52942) 1.02
css/parser/foundation_6_7_4 12894975 ns/iter (± 22222) 12723260 ns/iter (± 67638) 1.01
css/parser/tailwind_3_1_1 2546975 ns/iter (± 3000) 2513007 ns/iter (± 11407) 1.01
es/codegen/colors 726333 ns/iter (± 397454) 727131 ns/iter (± 394660) 1.00
es/codegen/large 3022400 ns/iter (± 1590152) 2972684 ns/iter (± 1577289) 1.02
es/codegen/with-parser/colors 40693 ns/iter (± 837) 40640 ns/iter (± 336) 1.00
es/codegen/with-parser/large 450998 ns/iter (± 5477) 450797 ns/iter (± 6524) 1.00
es/minify/libraries/antd 1590184932 ns/iter (± 25192746) 1457467261 ns/iter (± 45072515) 1.09
es/minify/libraries/d3 301942190 ns/iter (± 6150069) 282434792 ns/iter (± 3510944) 1.07
es/minify/libraries/echarts 1301964778 ns/iter (± 8155507) 1180769739 ns/iter (± 20108306) 1.10
es/minify/libraries/jquery 83242909 ns/iter (± 464600) 82772804 ns/iter (± 305821) 1.01
es/minify/libraries/lodash 105150852 ns/iter (± 234890) 104558336 ns/iter (± 167165) 1.01
es/minify/libraries/moment 48795112 ns/iter (± 536301) 48536119 ns/iter (± 64174) 1.01
es/minify/libraries/react 16372557 ns/iter (± 68062) 16311755 ns/iter (± 29237) 1.00
es/minify/libraries/terser 224222141 ns/iter (± 1656403) 217409933 ns/iter (± 1713871) 1.03
es/minify/libraries/three 397611980 ns/iter (± 4214017) 362121698 ns/iter (± 3099971) 1.10
es/minify/libraries/typescript 2880515103 ns/iter (± 28346585) 2749490581 ns/iter (± 61953199) 1.05
es/minify/libraries/victory 702683937 ns/iter (± 10023678) 590191441 ns/iter (± 8542936) 1.19
es/minify/libraries/vue 123156965 ns/iter (± 486496) 121248045 ns/iter (± 223965) 1.02
es/visitor/compare/clone 1736257 ns/iter (± 4300) 1714584 ns/iter (± 3053) 1.01
es/visitor/compare/visit_mut_span 2065484 ns/iter (± 10916) 2049076 ns/iter (± 16661) 1.01
es/visitor/compare/visit_mut_span_panic 2072945 ns/iter (± 58144) 2055053 ns/iter (± 59021) 1.01
es/visitor/compare/fold_span 2802599 ns/iter (± 29383) 2767224 ns/iter (± 3630) 1.01
es/visitor/compare/fold_span_panic 2835664 ns/iter (± 8788) 2820497 ns/iter (± 4495) 1.01
es/lexer/colors 10189 ns/iter (± 64) 9530 ns/iter (± 73) 1.07
es/lexer/angular 5236375 ns/iter (± 19198) 5117671 ns/iter (± 27679) 1.02
es/lexer/backbone 707902 ns/iter (± 10783) 632919 ns/iter (± 1277) 1.12
es/lexer/jquery 3956533 ns/iter (± 30265) 3621740 ns/iter (± 31462) 1.09
es/lexer/jquery mobile 5783746 ns/iter (± 21812) 5293327 ns/iter (± 71293) 1.09
es/lexer/mootools 3149624 ns/iter (± 14081) 3007571 ns/iter (± 42877) 1.05
es/lexer/underscore 583192 ns/iter (± 2501) 542824 ns/iter (± 7596) 1.07
es/lexer/three 17298443 ns/iter (± 81455) 17058669 ns/iter (± 16884) 1.01
es/lexer/yui 3100132 ns/iter (± 6548) 2995997 ns/iter (± 7543) 1.03
es/lexer/cal-com 14036647 ns/iter (± 58942) 13236470 ns/iter (± 36309) 1.06
es/lexer/typescript 96652966 ns/iter (± 276784) 92083212 ns/iter (± 326850) 1.05
es/parser/colors 23225 ns/iter (± 88) 23841 ns/iter (± 149) 0.97
es/parser/angular 12416758 ns/iter (± 59366) 12434265 ns/iter (± 82369) 1.00
es/parser/backbone 1822925 ns/iter (± 7311) 1813904 ns/iter (± 10055) 1.00
es/parser/jquery 10088462 ns/iter (± 54211) 10040618 ns/iter (± 59079) 1.00
es/parser/jquery mobile 15111839 ns/iter (± 79243) 15190820 ns/iter (± 76195) 0.99
es/parser/mootools 7772375 ns/iter (± 10950) 7823027 ns/iter (± 23568) 0.99
es/parser/underscore 1580789 ns/iter (± 4738) 1589824 ns/iter (± 6603) 0.99
es/parser/three 43514804 ns/iter (± 208253) 43623357 ns/iter (± 279761) 1.00
es/parser/yui 7375556 ns/iter (± 32021) 7527824 ns/iter (± 36990) 0.98
es/parser/cal-com 39357716 ns/iter (± 252776) 40528536 ns/iter (± 802028) 0.97
es/parser/typescript 267470477 ns/iter (± 906666) 269300229 ns/iter (± 3148936) 0.99
es/preset-env/usage/builtin_type 136654 ns/iter (± 33947) 137217 ns/iter (± 34934) 1.00
es/preset-env/usage/property 16470 ns/iter (± 82) 16944 ns/iter (± 82) 0.97
es/resolver/typescript 101233255 ns/iter (± 1287530) 97730136 ns/iter (± 1803625) 1.04
es/fixer/typescript 82210730 ns/iter (± 2615835) 80289322 ns/iter (± 3131916) 1.02
es/hygiene/typescript 182730344 ns/iter (± 4263215) 177292737 ns/iter (± 4205533) 1.03
es/resolver_with_hygiene/typescript 305641375 ns/iter (± 3233015) 302235696 ns/iter (± 3318277) 1.01
es/visitor/base-perf/module_clone 57379 ns/iter (± 357) 55752 ns/iter (± 424) 1.03
es/visitor/base-perf/fold_empty 60615 ns/iter (± 889) 59801 ns/iter (± 1029) 1.01
es/visitor/base-perf/fold_noop_impl_all 60362 ns/iter (± 498) 59770 ns/iter (± 957) 1.01
es/visitor/base-perf/fold_noop_impl_vec 60360 ns/iter (± 319) 59817 ns/iter (± 759) 1.01
es/visitor/base-perf/boxing_boxed_clone 60 ns/iter (± 0) 61 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_unboxed_clone 47 ns/iter (± 0) 54 ns/iter (± 0) 0.87
es/visitor/base-perf/boxing_boxed 105 ns/iter (± 0) 107 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_unboxed 80 ns/iter (± 0) 82 ns/iter (± 0) 0.98
es/visitor/base-perf/visit_contains_this 2609 ns/iter (± 11) 2578 ns/iter (± 7) 1.01
es/base/parallel/resolver/typescript 2534515067 ns/iter (± 149542798) 2412720808 ns/iter (± 183073097) 1.05
es/base/parallel/hygiene/typescript 3266219904 ns/iter (± 69585890) 3192717385 ns/iter (± 50969558) 1.02
babelify-only 493743 ns/iter (± 2381) 488641 ns/iter (± 9986) 1.01
parse_and_babelify_angular 41387641 ns/iter (± 1026672) 41637849 ns/iter (± 340006) 0.99
parse_and_babelify_backbone 4339388 ns/iter (± 172199) 4392504 ns/iter (± 135974) 0.99
parse_and_babelify_jquery 29118425 ns/iter (± 620332) 28716359 ns/iter (± 271986) 1.01
parse_and_babelify_jquery_mobile 50235688 ns/iter (± 454495) 51232958 ns/iter (± 553492) 0.98
parse_and_babelify_mootools 24889197 ns/iter (± 218270) 27305696 ns/iter (± 1417892) 0.91
parse_and_babelify_underscore 3701760 ns/iter (± 16735) 3667786 ns/iter (± 26387) 1.01
parse_and_babelify_yui 23192121 ns/iter (± 149270) 29547851 ns/iter (± 2293909) 0.78
html/minify/document/css_spec 49045769 ns/iter (± 1027504) 45109435 ns/iter (± 222195) 1.09
html/minify/document/github 19402960 ns/iter (± 199259) 18221919 ns/iter (± 142649) 1.06
html/minify/document/stackoverflow 17523825 ns/iter (± 288830) 16452896 ns/iter (± 589089) 1.07
html/minify/document_fragment/css_spec 48277495 ns/iter (± 1376575) 44415530 ns/iter (± 394927) 1.09
html/minify/document_fragment/github 19448121 ns/iter (± 375679) 17809911 ns/iter (± 84122) 1.09
html/minify/document_fragment/stackoverflow 17312314 ns/iter (± 170557) 16255740 ns/iter (± 16492) 1.06
html/document/visitor/compare/clone 166053 ns/iter (± 1721) 164609 ns/iter (± 3280) 1.01
html/document/visitor/compare/visit_mut_span 183492 ns/iter (± 3712) 183756 ns/iter (± 2385) 1.00
html/document/visitor/compare/visit_mut_span_panic 187784 ns/iter (± 7144) 188231 ns/iter (± 5831) 1.00
html/document/visitor/compare/fold_span 228154 ns/iter (± 1419) 233506 ns/iter (± 1255) 0.98
html/document/visitor/compare/fold_span_panic 280688 ns/iter (± 1529) 278456 ns/iter (± 2136) 1.01
html/document_fragment/visitor/compare/clone 166216 ns/iter (± 727) 167547 ns/iter (± 1140) 0.99
html/document_fragment/visitor/compare/visit_mut_span 181909 ns/iter (± 692) 184335 ns/iter (± 1823) 0.99
html/document_fragment/visitor/compare/visit_mut_span_panic 188268 ns/iter (± 1774) 188908 ns/iter (± 1381) 1.00
html/document_fragment/visitor/compare/fold_span 230314 ns/iter (± 1608) 232736 ns/iter (± 1287) 0.99
html/document_fragment/visitor/compare/fold_span_panic 277635 ns/iter (± 5127) 279188 ns/iter (± 1227) 0.99
html/lexer/css_2021_spec 12938142 ns/iter (± 21560) 12814810 ns/iter (± 219029) 1.01
html/lexer/github.com_17_05_2022 4944257 ns/iter (± 12047) 4938767 ns/iter (± 12227) 1.00
html/lexer/stackoverflow_com_17_05_2022 4672849 ns/iter (± 13368) 4677393 ns/iter (± 9264) 1.00
html/parser/parser_document/css_2021_spec 25313968 ns/iter (± 46346) 25956335 ns/iter (± 52780) 0.98
html/parser/parser_document/github.com_17_05_2022 8399552 ns/iter (± 26743) 8597158 ns/iter (± 21798) 0.98
html/parser/parser_document/stackoverflow_com_17_05_2022 7335424 ns/iter (± 127694) 7570452 ns/iter (± 7461) 0.97
html/parser/parser_document_fragment/css_2021_spec 24833812 ns/iter (± 335667) 25555555 ns/iter (± 42805) 0.97
html/parser/parser_document_fragment/github.com_17_05_2022 8324046 ns/iter (± 9489) 8538677 ns/iter (± 42749) 0.97
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7276445 ns/iter (± 8850) 7475235 ns/iter (± 9273) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.