Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Japanese translation of README #7176

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

ohno418
Copy link
Contributor

@ohno418 ohno418 commented Sep 19, 2022

Make some improvements and updates to the Japanese README.

README.ja.md Outdated

次のコマンドを実行してください:

meson build
ninja -C build
sudo ninja -C build install

logindを使用していないシステムでは、バイナリにsuidを設定する必要があります:
logindやseatdを使用していないシステムでは、swayバイナリをsuidする必要があります:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. This is technically a correct README fix, but suid support was removed some time back. We should update the English README accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll remove this part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ddevault
Copy link
Contributor

ddevault commented Oct 8, 2022

LGTM

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion enabled auto-merge (rebase) October 8, 2022 08:09
@emersion emersion merged commit 07c827b into swaywm:master Oct 8, 2022
@ohno418 ohno418 deleted the update-japanese-translation branch October 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants