Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safety assert in parse_movement_unit #6749

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Add safety assert in parse_movement_unit #6749

merged 1 commit into from
Jan 9, 2022

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 9, 2022

Let's add this just in case a caller passes argc == 0.

References: #6737 (comment)

cc @mstoeckl @David96

@emersion
Add safety assert in parse_movement_unit
aa3e22d 
Let's add this just in case a caller passes argc == 0.

References: swaywm#6737 (comment)
mstoeckl
mstoeckl approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@mstoeckl mstoeckl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I tested this by rebasing onto a branch without the fix (1bf1d84) to 6737 .

@emersion
Copy link
Member Author

emersion commented Jan 9, 2022

Thanks for the review!

@emersion emersion merged commit 6cb69a4 into swaywm:master Jan 9, 2022
@emersion emersion deleted the parse-movement-amount-assert branch January 9, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoeckl mstoeckl mstoeckl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersion @mstoeckl