Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document force_display_urgency_hint #5599

Merged
merged 2 commits into from
Aug 3, 2020
Merged

document force_display_urgency_hint #5599

merged 2 commits into from
Aug 3, 2020

Conversation

JayceFayne
Copy link
Contributor

fixes #5573

@emersion
Copy link
Member

emersion commented Aug 3, 2020

LGTM otherwise!

@emersion
Copy link
Member

emersion commented Aug 3, 2020

Thanks for splitting this up in two commits 👍

@JayceFayne JayceFayne force-pushed the document_force_display_urgency_hint branch 2 times, most recently from c7edb74 to a6fa44b Compare August 3, 2020 11:37
@JayceFayne
Copy link
Contributor Author

I pushed some code. Let me know if that covers the errors cases you mentioned 👍

@emersion
Copy link
Member

emersion commented Aug 3, 2020

The new error handling LGTM, except that it doesn't accept force_display_urgency_hint 500ms (without a space).

@JayceFayne
Copy link
Contributor Author

JayceFayne commented Aug 3, 2020 •
edited
Loading

Yes I noticed that limitation as well while looking through the i3 tests. But since its not really documented behaviour I'd say we could keeping it simple for now and maybe support that syntax later if needed?

@emersion
Copy link
Member

emersion commented Aug 3, 2020

The issue is that it was supported before this PR. We can't break existing user configurations.

@JayceFayne
Copy link
Contributor Author

Ofc, you are right, I'll try to fix it.

@JayceFayne JayceFayne force-pushed the document_force_display_urgency_hint branch from a6fa44b to 7f9355d Compare August 3, 2020 13:35
@JayceFayne JayceFayne force-pushed the document_force_display_urgency_hint branch from 7f9355d to 60d1302 Compare August 3, 2020 13:38
emersion
emersion approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion emersion merged commit 8fb9f3b into swaywm:master Aug 3, 2020
@JayceFayne JayceFayne deleted the document_force_display_urgency_hint branch August 3, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

force_display_urgency_hint is undocumented
2 participants
@JayceFayne @emersion