Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criteria: match containers without view #4949

Merged
merged 1 commit into from
Feb 5, 2020
Merged

criteria: match containers without view #4949

merged 1 commit into from
Feb 5, 2020

Conversation

anrdnet
Copy link
Contributor

@anrdnet anrdnet commented Jan 25, 2020

Closes #4929

Replaces criteria_get_views with criteria_get_containers which can
return containers without views when the criteria only contains
container properties.

@ddevault
Copy link
Contributor

What does i3 do about this?

@anrdnet
Copy link
Contributor Author

anrdnet commented Jan 25, 2020

i3 supports this, as can be tested by the following and similar examples:

$ i3-msg 'splitv'
$ xterm &
$ i3-msg 'focus parent; mark test; focus child'
$ i3-msg '[con_mark="test"] focus'

I made this patch because this feature was part of my i3 workflow, and it broke when I moved to sway.

Copy link
Member

@RedSoxFan RedSoxFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a few adjustments.

include/sway/criteria.h Outdated Show resolved Hide resolved
sway/criteria.c Show resolved Hide resolved
Copy link
Member

@RedSoxFan RedSoxFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs one small change. Other then that, LGTM

sway/criteria.c Outdated Show resolved Hide resolved
Closes #4929

Replaces criteria_get_views with criteria_get_containers which can
return containers without views when the criteria only contains
container properties.
@RedSoxFan RedSoxFan merged commit 4e46bdf into swaywm:master Feb 5, 2020
@RedSoxFan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Command criteria only match views
3 participants