Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaps: remove duplicate inner gaps #3086

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

RedSoxFan
Copy link
Member

Removes duplicate inner gaps between two containers. See #307 (comment).

Instead of dividing the gaps by two between two containers as suggested, I decided to do the following:

  1. Inner gaps are always added to the right and bottom sides
  2. Inner gaps are only added to the top side when the container's y location matches the workspace's y location without inner gaps applied
  3. Inner gaps are only added to the left side when the container's x location matches the workspace's x location without inner gaps applied

I think this solution is better since the inner gaps are guaranteed to be integer values instead of having to deal with half pixel values when dividing an odd inner gap by two.

@ddevault ddevault merged commit e53b481 into swaywm:master Nov 8, 2018
@ddevault
Copy link
Contributor

ddevault commented Nov 8, 2018

Thanks!

@RedSoxFan RedSoxFan deleted the fix-dup-inner-gaps branch November 8, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants