Switch to using a function to parse booleans #2340
Conversation
include/util.h
Outdated
| * toggling is not desired, pass in true for current so that toggling values | ||
| * get parsed as not true. | ||
| */ | ||
| bool parse_boolean(const char *boolean, const bool current); |
There was a problem hiding this comment.
The bool argument doesn't need to be const here
| @@ -123,6 +123,21 @@ uint32_t parse_color(const char *color) { | |||
| return res; | |||
| } | |||
|
|
|||
| bool parse_boolean(const char *boolean, bool current) { | |||
There was a problem hiding this comment.
Do we want to handle errors? (ie. bool parse_boolean(const char *str, bool current, bool *out))
There was a problem hiding this comment.
I thought this too, but it looks like the function returns false for invalid values and if that matches i3's behavior we should keep it.
There was a problem hiding this comment.
It would make sense to add a comment stating that.
There was a problem hiding this comment.
What about case sensitivity? Shouldn't these use strcasecmp?
There was a problem hiding this comment.
It would make sense to add a comment stating that.
Added
What about case sensitivity? Shouldn't these use
strcasecmp?
Fixed
|
Thanks! |
Related to #2336.
This PR adds a function (
parse_boolean) similar to i3'seval_boolstr. The onlytruevalue that I added wasenabledsince that was in use for various commands. The rest are identical to i3's.I also added support for toggling values. Currently, toggling is not supported for
inputoroutputcommands (since it would require a change to the way their configs work, which is out of scope for this PR), but should work for anything else that takes a boolean value. Forinputandoutputcommands,toggleis interpreted as a non-true value.