Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues with spaces in workspace names #1384

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Fix two issues with spaces in workspace names #1384

merged 2 commits into from
Oct 6, 2017

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Oct 6, 2017

In two cases, the workspace name was cropped until the first space:

  • when moving a container to a workspace
  • when finding a suitable name for a workspace (by parsing the configuration file)

The workspace xx command is already behaving correctly but there might be some other instances of this error.

@lbonn
Fix move to named workspaces
6197fff 
The command parsing did not handle workspaces with spaces in their name
(like it's done in `cmd_workspace`)
@lbonn
Make workspace_next_name work with spaces
a7e1a0e 
`workspace_next_name` parses workspace commands to find the default
workspace names. It handled " " as a separator, which prevents the use
of workspace names with spaces.
@ddevault ddevault merged commit fff684b into swaywm:master Oct 6, 2017
@ddevault
Copy link
Contributor

ddevault commented Oct 6, 2017

Thanks!

@ddevault ddevault mentioned this pull request Oct 7, 2017
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbonn @ddevault